fix: in_foreground and is_active app context #7188
Draft
+37
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the mismatch of the app context in foreground between fatal and non-fatal events. Also, fix the breadcrumbs to correctly add in_foreground and in background crumbs, and add new active crumbs for more info for the user. Fixes GH-6178
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Metrics
Other
Bug Fixes 🐛
Build / dependencies / internal 🔧Deps
Other
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Fixes
- in_foreground and is_active app context ([#7188](https://github.com/getsentry/sentry-cocoa/pull/7188))If none of the above apply, you can opt out of this check by adding |
philipphofmann
commented
Jan 16, 2026
| - (void)trackApplicationNotifications | ||
| { | ||
| #if SENTRY_HAS_UIKIT | ||
| NSNotificationName foregroundNotificationName = UIApplicationDidBecomeActiveNotification; |
Member
Author
There was a problem hiding this comment.
Here's a key change. The foreground crumb now gets added when UIApplicationWillEnterForegroundNotification and not when UIApplicationDidBecomeActiveNotification. I think that's more accurate.
philipphofmann
commented
Jan 16, 2026
Comment on lines
-726
to
-727
| BOOL inForeground = appState == UIApplicationStateActive; | ||
| app[@"in_foreground"] = @(inForeground); |
Member
Author
There was a problem hiding this comment.
Here was the mismatch between fatal and non-fatal events. Here we used to set in_foreground to true if the app was active, but the app could also be in the foreground but not active and then this was false before. Now it's aligned with SentryCrash
sentry-cocoa/Sources/SentryCrash/Recording/SentryCrash.m
Lines 521 to 539 in 7e93d85
❌ 3 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
itaybre
reviewed
Jan 16, 2026
| withDataValue:@"foreground"]; | ||
| }]; | ||
|
|
||
| [NSNotificationCenter.defaultCenter addObserverForName:didBecomeActiveNotificationName |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
This is still a draft PR, I would love to get some feedback on the chosen approach. I initially wanted to fix only the in_foreground app context, but then I realized there's a benefit in knowing if the app is in the foreground, but also if it's active or not. If we agree that this is the right approach, I'm going to add tests.
Fix the mismatch of the app context in foreground between fatal and non-fatal events. Also, fix the breadcrumbs to correctly add in_foreground and in background crumbs, and add new active crumbs for more info for the user.
💡 Motivation and Context
Fixes GH-6178
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.