Dispatch session replay to main thread #6082
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Ensures Session Replay
resume
andpauseSessionMode
operations are dispatched to the main thread when network connectivity changes.💡 Motivation and Context
The
connectivityChanged
callback, which signals network status, can be invoked on a background thread. Directly callingSentrySessionReplay
'sresume
orpauseSessionMode
from this background thread can lead to a race condition with the session tracker, which is initialized and managed on the main thread. This race condition has been observed to causeEXC_BAD_ACCESS
crashes. By dispatching these operations to the main thread, we ensure thread safety and prevent these crashes.💚 How did you test it?
No specific tests were added or run during the conversation. This is a logical fix based on thread safety principles.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.Slack Thread