fix(relevant-warnings) Read PR instead of commit #2128
Merged
+86
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddubey
commented
Mar 10, 2025
| def _fetch_issues_for_pr_file_cache_key( | ||
| organization_id: int, provider: str, external_id: str, pr_file: PrFile, *args | ||
| ) -> tuple[str]: | ||
| return hashkey(organization_id, provider, external_id, pr_file.filename, pr_file.sha) |
There was a problem hiding this comment.
the commit before this implemented PrFile.__hash__ and PrFile.__eq__ and passed pr_file here instead. but that causes the hash key to be the whole PrFile obj, which can include a large patch. keep the key small by manually passing the filename and sha
kddubey
commented
Mar 10, 2025
| patch=file.patch, | ||
| status=file.status, | ||
| changes=file.changes, | ||
| sha=file.sha, |
There was a problem hiding this comment.
this is indeed the blob SHA
jennmueng
approved these changes
Mar 10, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context in slack