Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autofix): Coding follows a solution from UI #2098

Merged
merged 3 commits into from
Mar 6, 2025

Conversation

jennmueng
Copy link
Member

@jennmueng jennmueng commented Mar 6, 2025

Le coding agent will follow the solution passed from the UI, and we also store which is active or not

Key change is on the update call, the frontend can pass a solution to be set

Custom solution is removed on frontend, keeping it here for backwards compat

Comment on lines +19 to +20
code_snippet_and_analysis: str | None = None
relevant_code_file: RelevantCodeFile | None = None
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

human instruction will only have title

is_most_important_event: bool = False
event_type: Literal["internal_code"] | str = "internal_code"
timeline_item_type: Literal["internal_code", "human_instruction"] = "internal_code"
Copy link
Member Author

@jennmueng jennmueng Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was timeline_item_type on the frontend, and we were sending event_type, but it worked cuz everything was internal code anyways lol

@jennmueng jennmueng requested a review from roaga March 6, 2025 00:49
@jennmueng jennmueng marked this pull request as ready for review March 6, 2025 00:49
@jennmueng jennmueng requested a review from a team as a code owner March 6, 2025 00:49
@jennmueng jennmueng enabled auto-merge (squash) March 6, 2025 19:13
@jennmueng jennmueng merged commit 16f907f into main Mar 6, 2025
22 checks passed
@jennmueng jennmueng deleted the jenn/autofix/solution-followng branch March 6, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants