-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(spooler): Remove use of legacy project cache #4419
base: master
Are you sure you want to change the base?
Conversation
pub own_key: ProjectKey, | ||
pub sampling_key: ProjectKey, | ||
own_key: ProjectKey, | ||
sampling_key: Option<ProjectKey>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided that I would prefer to encode in the pair the lack of sampling key and rather expose different methods for making it behave like previously, where they were both set and the fallback of sampling_key
was own_key
.
pub own_key: ProjectKey, | ||
pub sampling_key: ProjectKey, | ||
own_key: ProjectKey, | ||
sampling_key: Option<ProjectKey>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided that I would prefer to encode in the pair the lack of sampling key and rather expose different methods for making it behave like previously, where they were both set and the fallback of sampling_key
was own_key
.
This PR removes the old legacy project cache and implements the forwarding logic directly in the spooler. The new logic works as follows: