-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(processor): Remove the processor state #4416
Conversation
|
||
/// The partial result of the envelope processing. | ||
#[derive(Debug)] | ||
enum ProcessingPartialResult { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created this partial result to be more clear about the fact that this result is not the full one because the envelope is added afterwards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have ProcessingExtractedMetrics
on the ProcessingResult
instead? That would make it simpler to understand IMO, with a PartialResult type the reader has to follow one additional hop.
|
||
/// The partial result of the envelope processing. | ||
#[derive(Debug)] | ||
enum ProcessingPartialResult { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have ProcessingExtractedMetrics
on the ProcessingResult
instead? That would make it simpler to understand IMO, with a PartialResult type the reader has to follow one additional hop.
@jjbayer yes, I could do that. The reason for my partial result struct is that I liked the |
This PR removes the processor state. The state object is what prevented us from taking a stab at refactoring processing groups in Relay.
In upcoming PRs, the new processor refactor will take place.
#skip-changelog