Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(billing): Uptime DataCategory #4363

Merged
merged 3 commits into from
Dec 11, 2024
Merged

feat(billing): Uptime DataCategory #4363

merged 3 commits into from
Dec 11, 2024

Conversation

jarrettscott
Copy link
Contributor

@jarrettscott jarrettscott commented Dec 10, 2024 •
edited
Loading

@jarrettscott jarrettscott marked this pull request as ready for review December 10, 2024 17:23
@jarrettscott jarrettscott requested a review from a team as a code owner December 10, 2024 17:23
@jarrettscott jarrettscott requested a review from a team December 10, 2024 18:33
vbro
vbro approved these changes Dec 10, 2024
View reviewed changes
Copy link

@vbro vbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (billing)
Wait for Relay / Ingest approval before merging

Dav1dde
Dav1dde approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please add a note to py/CHANGELOG.md

CHANGELOG.md Outdated Show resolved Hide resolved
@jarrettscott jarrettscott merged commit 21aad1e into master Dec 11, 2024
23 checks passed
@jarrettscott jarrettscott deleted the jarrett/add-uptime-data-category branch December 11, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbro vbro vbro approved these changes

@Dav1dde Dav1dde Dav1dde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jarrettscott @Dav1dde @vbro