Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(metric-meta): Removes all metric meta code from Relay #4152

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented Oct 18, 2024

Metrics are soon to be shut down, this is one part of the code which is no longer required.

Existing metric-meta envelope items are handled as unknown from this version on forward.

@Dav1dde Dav1dde requested a review from a team as a code owner October 18, 2024 09:01
@Dav1dde Dav1dde force-pushed the dav1d/remove-metric-meta branch 2 times, most recently from 3691d66 to d6390d2 Compare October 18, 2024 09:06
Copy link
Member

@iambriccardo iambriccardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels damn good, LGTM.

Only one question, when do we want to shut this down? I recall we will keep metrics enabled for some customers for an extended period of time.

@shellmayr
Copy link
Member

Feels damn good, LGTM.

Only one question, when do we want to shut this down? I recall we will keep metrics enabled for some customers for an extended period of time.

AFAIK Nov 7 at the earliest

@Dav1dde Dav1dde self-assigned this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants