Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eap): Extract user IP #4144

Merged
merged 2 commits into from
Oct 16, 2024
Merged

feat(eap): Extract user IP #4144

merged 2 commits into from
Oct 16, 2024

Conversation

Zylphrex
Copy link
Member

This starts extracting user IP from the transaction into sentry tags.

@Zylphrex
feat(eap): Extract user IP
a617669 
This starts extracting user IP from the transaction into sentry tags.
@Zylphrex Zylphrex requested a review from a team October 15, 2024 14:36
@Zylphrex Zylphrex requested a review from a team as a code owner October 15, 2024 14:36
jjbayer
jjbayer approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the IP need to be indexed? If not, we can also put it in span.data.

@Zylphrex
Copy link
Member Author

Does the IP need to be indexed? If not, we can also put it in span.data.

The intention is to have it indexed

@Zylphrex Zylphrex merged commit 7fbf4ca into master Oct 16, 2024
23 checks passed
@Zylphrex Zylphrex deleted the txiao/feat/extract-user-ip branch October 16, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjbayer jjbayer jjbayer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zylphrex @jjbayer