Skip to content

Commit

Permalink
fix(ua): Update ua regexes (#4385)
Browse files Browse the repository at this point in the history
The user agent `Mozilla/5.0 (Linux; Android 14; SC-53D
Build/UP1A.231005.007; wv) AppleWebKit/537.36 (KHTML, like Gecko)
Version/4.0 Chrome/131.0.6778.104 Mobile Safari/537.36
jp.pay2.app.android/4.72.1` is misidentified as `Phantom`, with the
updated `uap-core` this is now correctly identified:

Before:
```
[relay-ua/src/lib.rs:58:5] parse_user_agent("Mozilla/5.0 (Linux; Android 14; SC-53D Build/UP1A.231005.007; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/131.0.6778.104 Mobile Safari/537.36 jp.pay2.app.android/4.72.1") = UserAgent {
    family: "Phantom",
    major: Some(
        "4",
    ),
    minor: Some(
        "72",
    ),
    patch: Some(
        "1",
    ),
}
```

After:
```
[relay-ua/src/lib.rs:58:5] parse_user_agent("Mozilla/5.0 (Linux; Android 14; SC-53D Build/UP1A.231005.007; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/131.0.6778.104 Mobile Safari/537.36 jp.pay2.app.android/4.72.1") = UserAgent {
    family: "Chrome Mobile WebView",
    major: Some(
        "131",
    ),
    minor: Some(
        "0",
    ),
    patch: Some(
        "6778",
    ),
}
```
  • Loading branch information
Dav1dde authored Dec 13, 2024
1 parent 89982f7 commit 1401169
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

**Bug Fixes**:

- Update user agent parsing rules to fix some user agent identification issues. ([#4385](https://github.com/getsentry/relay/pull/4385))
- Stop collecting the `has_profile` metrics tag & reporting outcomes for it. ([#4365](https://github.com/getsentry/relay/pull/4365))
- Parse unreal logs into breadcrumbs from all attached log items not just the first. ([#4384](https://github.com/getsentry/relay/pull/4384))

Expand Down
2 changes: 1 addition & 1 deletion relay-ua/uap-core

0 comments on commit 1401169

Please sign in to comment.