-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow for passing custom merge target #838
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renders a new field in the publish action to type in? Can it be prefiled with the repo's main branch name?
Yes, it renders the new field if configured in the target repo. It cannot be prefilled because this repo, nor |
|
I’ll research that. It would be nice, as we could remove default parsing override in publish repo, as the value would be always there. |
src/publish/inputs.js
Outdated
const mergeTargetParser = /^Merge target: (?<merge_target>.+)$/m; | ||
let { merge_target } = context.payload.issue.body.match( | ||
mergeTargetParser | ||
).groups; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be optional until everybody gets to the latest version of action-prepare-release. Otherwise you'll have lots of failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, forgot about the fallback for destructuring. Because other than this, merge_target
can be undefined, as it should evaluate to empty env variable, thus being skipped in cli call. (not that I haven't test any of this yet, as its not decided what we'll do with the original issue just yet).
I cannot find any way to use dynamic value for I'm also starting to wonder if there is even a point doing this, as |
I'd just leave it empty so Craft does "the right thing"™️ |
@kamilogorek would be great if we add a section to the readme on how to publish from/to a non-default branch similar to how we describe "CalVer". |
See getsentry/craft#355 for more details.