feat(commands): Add update command #75
Open
+318
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertdeng123
commented
Oct 17, 2024
| @@ -68,6 +71,14 @@ def main() -> None: | |||
| else: | |||
| parser.print_help() | |||
|
|
|||
| if args.command != "update": | |||
There was a problem hiding this comment.
I can see a major downside to this:
If user is not connected to internet, this will error out and cause spam. I think it is ok to leave it as is and put a workaround in later though
There was a problem hiding this comment.
Ultimately, it is far more useful to notify users to update if available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the update command to devservices
For global installs, this will download the latest binary off of GitHub, detect the correct binary for linux/darwin operating systems, and automatically install. It will also automatically check for update after each invocation of devservices.
For installs in virtual environments, it prints instructions to update the requirements.txt.