This repository has been archived by the owner on Aug 14, 2024. It is now read-only.
W3C traceparent #1136
Merged
W3C traceparent #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mydea
approved these changes
Apr 9, 2024
Lms24
reviewed
Apr 9, 2024
| @@ -117,7 +117,8 @@ tree as well as the unit of reporting to Sentry. | |||
| - `Span` should have a method `startChild` which creates a new span with the current span's id as the new span's `parentSpanId` and the current span's `sampled` value copied over to the new span's `sampled` property | |||
| - The `startChild` method should respect the `maxSpans` limit, and once the limit is reached the SDK should not create new child spans for the given transaction. | |||
| - `Span` should have a method called `toSentryTrace` which returns a string that could be sent as a header called `sentry-trace`. | |||
| - `Span` should have a method called `iterHeaders` (adapt to platform's naming conventions) that returns an iterable or map of header names and values. This is a thin wrapper containing `return {"sentry-trace": toSentryTrace()}` right now. See `continueFromHeaders` as to why this exists and should be preferred when writing integrations. | |||
| - `Span` should have a method called `toW3CTrace` which returns a string that could be sent as a header called `traceparent`. | |||
There was a problem hiding this comment.
side note: These docs here assume our SDKs create spans themselves. This is no longer the case in Otel-based SDKs (e.g. JS Node), so we can't define most of these methods on a span/transaction interface. Instead we expose top level helper functions in JS. I think it's fine to keep things as-is in this PR but we probably wanna rework this page a bit to keep things up to date.
Co-authored-by: Lukas Stracke <[email protected]>
Co-authored-by: Lukas Stracke <[email protected]>
Lms24
approved these changes
Apr 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getsentry/team-sdks#41