Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Minor linter issues #520

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Minor linter issues #520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1aa693b
add missing gem cleanup
vaind Feb 27, 2024
fce3902
autofixed settings.json
vaind Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"editor.codeActionsOnSave": {
"source.organizeImports": false
"source.organizeImports": "never"
},
"editor.formatOnType": true,
"editor.formatOnSave": true,
Expand Down
1 change: 1 addition & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ RUN : \
&& cargo --version \
&& cargo install cargo-hack \
&& gem install -g --no-document \
&& gem cleanup all \
Comment on lines 71 to +72
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just because I'm curious -- what does this do? reading the output it looks like it didn't really uninstall anything:

#16 109.4 Cleaning up installed gems...
#16 109.4 Clean up complete

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess nothing in this case, it's just what linter said is missing there. To me it sounds like having apt-get clean or apt-get autoremove - you may not need it most of the time but if you do, it's there and no need to come back to the image and investigate whether you can decrease the size.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what linter ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some extension in vscode uses these: https://github.com/projectatomic/dockerfile_lint

# Install https://github.com/getsentry/symbol-collector
&& symbol_collector_url=$(curl -s https://api.github.com/repos/getsentry/symbol-collector/releases/tags/1.17.0 | \
jq -r '.assets[].browser_download_url | select(endswith("symbolcollector-console-linux-x64.zip"))') \
Expand Down
Loading