fix(crates): Skip path-only dev-dependencies in dep cycle checking (#341

)
getsentry · Jan 14, 2022 · 2ff325e · 2ff325e
1 parent 03fda08
commit 2ff325e
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/targets/crates.ts b/src/targets/crates.ts
@@ -185,7 +185,12 @@ export class CratesTarget extends BaseTarget {
     const isWorkspaceDependency = (dep: CrateDependency) => {
       // Optionally exclude dev dependencies from dependency resolution. When
       // this flag is provided, these usually lead to circular dependencies.
-      if (this.cratesConfig.noDevDeps && dep.kind === 'dev') {
+      // Path-only dependencies are designated by `req = *`, and are not being
+      // validated by cargo on publish.
+      if (
+        dep.kind === 'dev' &&
+        (dep.req === '*' || this.cratesConfig.noDevDeps)
+      ) {
         return false;
       }