fix: Add optional to type chain (#560)

* Add optional to type chain * Add tests
getsentry · Oct 28, 2024 · 0386937 · 0386937
1 parent 395a38c
commit 0386937
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/src/utils/__tests__/changelog.test.ts b/src/utils/__tests__/changelog.test.ts
@@ -290,7 +290,7 @@ describe('generateChangesetFromGit', () => {
     pr?: {
       local?: string;
       remote?: {
-        author: { login: string };
+        author?: { login: string };
         number: string;
         body?: string;
         milestone?: string;
@@ -389,6 +389,19 @@ describe('generateChangesetFromGit', () => {
       {},
       '### Various fixes & improvements\n\n- Upgraded the kernel (#123) by @sentry',
     ],
+    [
+      'Does not error when PR author is null',
+      [
+        {
+          hash: 'abcdef1234567890',
+          title: 'Upgraded the kernel',
+          body: '',
+          pr: { remote: { number: '123' } },
+        },
+      ],
+      {},
+      '### Various fixes & improvements\n\n- Upgraded the kernel (#123)',
+    ],
     [
       'handle multiple commits properly',
       [

diff --git a/src/utils/changelog.ts b/src/utils/changelog.ts
@@ -380,7 +380,7 @@ interface CommitInfo {
     nodes: Array<{
       number: string;
       body: string;
-      author: {
+      author?: {
         login: string;
       };
       milestone: {
@@ -472,7 +472,7 @@ async function getPRAndMilestoneFromCommit(
         hash.slice(1),
         pr
           ? {
-              author: pr.author.login,
+              author: pr.author?.login,
               pr: pr.number,
               prBody: pr.body,
               milestone: pr.milestone?.number ?? null,