Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigquery load schema diff locations ignore #7289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lee2532
Copy link

@Lee2532 Lee2532 commented Jan 17, 2025

What type of PR is this?

  • Bug Fix

Description

An error occurs when retrieving the BigQuery schema if there are datasets located in different regions. This update ensures that the correct region is specified to prevent such issues.

How is this tested?

  • Manually

if dataset location is different then
set location : asia-northeast3
test-dataset-location : US
Not fount: dataset test-data-set was not found in location asia-northeast3

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.00%. Comparing base (4ee53a9) to head (e83fa23).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
redash/query_runner/big_query.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7289      +/-   ##
==========================================
- Coverage   64.01%   64.00%   -0.02%     
==========================================
  Files         163      163              
  Lines       13410    13413       +3     
  Branches     1905     1906       +1     
==========================================
  Hits         8585     8585              
- Misses       4490     4493       +3     
  Partials      335      335              
Files with missing lines Coverage Δ
redash/query_runner/big_query.py 23.56% <0.00%> (-0.38%) ⬇️

@yoshiokatsuneo
Copy link
Contributor

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants