Skip CI if-and-only-if run from a non-fork PR #369
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failure to produce a build artifact on merge to
main. (Or at least, I think it fixes that!)Closes # (do we have an issue for this?)
I have verified this PR works in these browsers (latest versions):
What else has been done to verify that this works as intended?
After the first failed attempt in #368, I did a bunch of trial and error in a private personal repo. Note: I haven't validated the fork-specific logic (because no fork of private personal repo)! But I have validated that jobs predicated on that condition run as expected (and don't run for a negative predicate result).
Why is this the best possible solution? Were any other approaches considered?
It probably isn't the best possible solution!
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
I could imagine a few hundred ways this breaks assumptions we have about CI. But the real risk is the ways I can't imagine. Such is the nature of GitHub Actions!
Do we need any specific form for testing your changes? If so, please attach one.
N/A
What's changed
CI will now be skipped if triggered by a
pull_requestevent, except if the PR is from a fork... where "from a fork" is defined asrepository_ownerbeing some value other than'getodk'.