Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu/MenuItem as Ui Components #6970

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Menu/MenuItem as Ui Components #6970

merged 3 commits into from
Feb 4, 2025
+435 −235

Conversation

distantnative
Copy link
Member

  • Menu and MenuItem are Ui\Component classes
  • Move all panel module specific code out of k-panel-menu
  • Allow config options that include a Ui\Component object directly
    • Not really meant for anything now, but I could see this a way for customization for developers to include something else than menu buttons in the menu (e.g. headlines for button groups)

@distantnative distantnative force-pushed the v5/refactor/panel-php-part-3 branch 2 times, most recently from 048982b to 97c63bf Compare February 3, 2025 19:31
@distantnative distantnative mentioned this pull request Feb 3, 2025
Merged
@distantnative distantnative force-pushed the v5/refactor/panel-php-part-3 branch from 97c63bf to fa594ae Compare February 3, 2025 19:46
@bastianallgeier bastianallgeier marked this pull request as ready for review February 4, 2025 11:05
bastianallgeier

This comment was marked as outdated.

Sign in to view

@bastianallgeier bastianallgeier merged commit 0f58771 into v5/refactor/panel-php-part-2 Feb 4, 2025
14 checks passed
@bastianallgeier bastianallgeier deleted the v5/refactor/panel-php-part-3 branch February 4, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@distantnative @bastianallgeier