Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New backup command #62

Merged
merged 5 commits into from
Feb 27, 2024
Merged

New backup command #62

merged 5 commits into from
Feb 27, 2024

Conversation

afbora
Copy link
Member

@afbora afbora commented Feb 22, 2024

No description provided.

@afbora afbora added the type: feature 🎉 Adds a feature (requests → feedback.getkirby.com) label Feb 22, 2024
@afbora afbora added this to the 1.4.0 milestone Feb 22, 2024
@afbora afbora requested a review from a team February 22, 2024 17:32
@afbora afbora self-assigned this Feb 22, 2024
commands/backup.php Outdated Show resolved Hide resolved
@distantnative
Copy link
Member

I am not sure I understand the purpose of the root argument. Like if someone just wants to backup blueprints?

@afbora
Copy link
Member Author

afbora commented Feb 22, 2024

I am not sure I understand the purpose of the root argument. Like if someone just wants to backup blueprints?

Yes. For ex, backup only content or site or accounts folder.

@distantnative
Copy link
Member

I think that should be reflected in the backup name then. Otherwise it might be hard to know which file is a full backup, which just a part etc.

@afbora afbora requested a review from a team February 22, 2024 21:53
commands/backup.php Outdated Show resolved Hide resolved
commands/backup.php Outdated Show resolved Hide resolved
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few small adjustments again, but overall this is also really cool.

@bastianallgeier bastianallgeier merged commit 72c2477 into develop Feb 27, 2024
10 checks passed
@bastianallgeier bastianallgeier deleted the feature/backup branch February 27, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature 🎉 Adds a feature (requests → feedback.getkirby.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants