Improve exception handling for argument parsing

getkirby · Feb 5, 2024 · fd26c83 · fd26c83
1 parent 1d6d72f
commit fd26c83
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/src/CLI/CLI.php b/src/CLI/CLI.php
@@ -518,12 +518,11 @@ public function run(?string $name = null, ...$args): void
 			...$args
 		];
 
-		$exception = null;
-
 		try {
 			$this->climate->arguments->parse($argv);
 		} catch (Throwable $e) {
-			$exception = $e;
+			$this->error($e->getMessage());
+			exit;
 		}
 
 		// enable quiet mode
@@ -537,10 +536,6 @@ public function run(?string $name = null, ...$args): void
 			return;
 		}
 
-		if ($exception !== null) {
-			throw $exception;
-		}
-
 		$command['command']($this);
 	}