Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openapi3: update date schema formats to not match months or days of '00' #1042

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

RulerOfTheQueendom
Copy link
Contributor

@RulerOfTheQueendom RulerOfTheQueendom commented Dec 11, 2024

Does what it says on the tin, per the permissible value range for date-month and date-mday of section 5.6 of the RFC3339 standard

EDIT TO ADD:
Also updates hours, minutes, and seconds to be bounded from 00-23, 00-59, and 00-60 respectively (the 60 is for the leap second).

@RulerOfTheQueendom
Copy link
Contributor Author

This PR addresses issue #1043

.github/docs/openapi3.txt Outdated Show resolved Hide resolved
.github/docs/openapi3.txt Outdated Show resolved Hide resolved
.github/docs/openapi3.txt Outdated Show resolved Hide resolved
@RulerOfTheQueendom
Copy link
Contributor Author

@fenollp I'm not sure what the merge process is, but it looks like you're pretty involved in it. Mind taking a look? :)

@fenollp fenollp changed the title Update date schema formats to not match months or days of '00' openapi3: update date schema formats to not match months or days of '00' Dec 11, 2024
@fenollp fenollp merged commit b82c647 into getkin:master Dec 11, 2024
5 checks passed
@fenollp
Copy link
Collaborator

fenollp commented Dec 11, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: '00' is erroneously matched for months and days in date and date-time validation regexes
3 participants