Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openapi3: use Ptr instead of BoolPtr,Float64Ptr,Int64Ptr,Uint64Ptr #1033

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

openapi3: use Ptr instead of BoolPtr,Float64Ptr,Int64Ptr,Uint64Ptr #1033

wants to merge 1 commit into from

Conversation

alexandear
Copy link
Contributor

This adds generic openapi3.Ptr function to be used instead of openapi3.BoolPtr, openapi3.Float64Ptr, openapi3.Int64Ptr, openapi3.Uint64Ptr.

@alexandear alexandear force-pushed the openapi3/ptr branch 2 times, most recently from 59997e4 to cbe9616 Compare November 26, 2024 16:54
@fenollp
Copy link
Collaborator

fenollp commented Nov 26, 2024

I fail to see the improvement here. Today's explicitly typed functions make it much easier to grasp their purpose and to find IMO. Thoughts?

@alexandear
Copy link
Contributor Author

I fail to see the improvement here. Today's explicitly typed functions make it much easier to grasp their purpose and to find IMO. Thoughts?

I intend to introduce' Ptr' to shorten BoolPtr, Float64Ptr, Int64Ptr, Uint64Ptr. Fewer symbols - same meaning. And this reduces the number of functions to remember for the library users.

See these PRs where Ptr was recently introduced:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccoVeille ccoVeille ccoVeille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandear @fenollp @ccoVeille