Consolidate base tsconfig settings #494
Open
+55
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidated the new tsconfig.dev.json into the existing, default tsconfig.json. Deleted the "build:types" script since it's been absorbed into "build:module", which now uses the tsconfig.json.
I like to test with npm pack, so this is just a QOL thing for me :)
I figure we don't care too much about node v10 anymore, so I updated the engines field to use node >=14.0.0—allowing us to update the tsconfig target to ES2020.
I think, with the current build process, the best way to simplify the tsc config(s) is actually to keep things separate. Part of the complication is that we build dist-node out of dist-module (which I still don't quite understand why)
I believe, with the way we use tsc with multiple input and output directories, this is the cleanest way to setup the configuration. Now: - tsconfig.json: shared base tsc settings - tsconfig.module.json: src -> dist-module compilation - tsconfig.node.json: dist-module -> dist-node recompilation As far as I can tell, this pretty much preserves the existing build process, just simplifies the settings (and should work better with tooling). The recompilation of dist-module to create dist-node is still undesirable, but I also still don't quite understand the whole reasoning there, so I don't want to touch it.
Didn't realize my changes to package-lock.json were in error, but CI seems to think so. Regenerated with `npm install`.
Regenerated package-lock.json to resolve merge conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Consolidates the shared
tscsettings intotsconfig.json, and specific build settings intotsconfig.module.jsonandtsconfig.node.json.Aims to resolve #493.
Details
Aside from updating to ES2020 in
dist-nodeand the addition ofsourceMaps indist-module, this should not alter the build or exports.tsconfig
tsconfig.json: sharedcompilerOptionsbetweenbuild:moduleandbuild:node. Does not reference any files, or specify an output.tsconfig.module.json: input & output settings forsrc -> dist-modulecompilation.tsconfig.node.json: input & output settings fordist-module -> dist-noderecompilation.package.json
engines.node >= 14: increased the minimum node version to 14, which AFAICT allows increasing thetsconfig.json"target"to"ES2020".build:typesscript: types are now generated bybuild:module.build:rebuildscript:compositetscconfiguration introducesincrementalcompilation and*.tsbuildinfoartifacts.build:clean, but that defeats the purpose and benefit ofincrementalbuilds. I figure it'll be less of a problem in actual usage.rm -rf ;withrimraf &&: based on Actually fix windows build #190, I believe this is the last outstanding change needed.