Add WellKnownName's to support extra styles from QGIS #828
+1,407
−768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there may still be an issue with zoom styling. It seems to apply the first style, but ignores subsequent ones. |
Tried using async to manage SVG loading for pattern fills, but it broke the style functions. Reverted back to using RegularShapes for pattern fills to avoid timing issues with loading. Added a number of extra RegularShapes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support for a large number of WellKnownName's has been added. This is to align with the point markers provided in the styling used with QGIS. Most of the new styles could not be replicated using OpenLayer's RegularShape specification, which is quite limited. As a result styling for points has been changed to use OpenLayer's Icon styles with SVG used for the image source. In most cases the SVG code for shapes was translated directly from the QGIS Python code.
The code has been tested as much as possible, but I have mainly been concentrating on converting SLD (from QGIS Server) to OpenLayers, and this seems to be working pretty well. I've had limited exposure to the other parts of Geostyler, so please let me know if there are other areas that need attention. I completely understand that there may be a lot of work needed, but hopefully it can be incorporated at some point. An attempt was made to use it with Geostyler Demo, but I think there might be other issues with this repository, as I couldn't get my fork working without the code changes.
Good luck!!
Related issues or pull requests
The following pull requests are related due to the new definition of the accepted WellKnownTypes.
Geostyler Style - geostyler/geostyler-style#652
Geostyler SLD Parser - geostyler/geostyler-sld-parser#978
Pull request type
Please check the type of change your PR introduces:
Do you introduce a breaking change?
Checklist
npm testlocally)