bench script + fixed python bench #123
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nuts_rice <[email protected]>
nuts-rice
force-pushed
the
python_rust_benches
branch
from
f879d42 to
0e2736e
Compare
kylebarron
reviewed
Apr 30, 2025
Member
There was a problem hiding this comment.
I'd prefer using a basic pyproject.toml here using uv https://docs.astral.sh/uv/, so the benches are repeatable
| geoindex-rs | ||
| geopandas | ||
| pyogrio | ||
| pyarrow |
Member
There was a problem hiding this comment.
you're also missing requests, numpy, shapely from the dependency list
| import shapely | ||
|
|
||
|
|
||
| gdf = gpd.read_file("Utah.geojson.zip", engine="pyogrio") |
Member
There was a problem hiding this comment.
This file is from https://github.com/microsoft/USBuildingFootprints#download-links, with a download link (unsure if this is persistent) of https://minedbuildings.z5.web.core.windows.net/legacy/usbuildings-v2/Utah.geojson.zip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to address #120 by having a script to run both rust and python benchmarks
The script so far:
generate_data.pyandrtree.pycargo benchfor regular target and therayonfeaturertree.pyrtree.pyis WIP now, I attempted to follow closely tobench.pywith some fixes for building the r-tree.The resources used by
generate_data.pyandbench.pywere broken so I've replaced them with other geojson and parquet datasets respectively