Airflow workflow to run push_to_airflow.sh #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 27, 2025 10:52
|
No need for rebasing 👍 |
rggelles
approved these changes
Oct 29, 2025
Member
rggelles
left a comment
rggelles
left a comment
There was a problem hiding this comment.
LGTM! Did you switch service accounts because you wanted to give the new one specific permissions for this?
Contributor
Author
Yeah, the highest level the service account for gsutil/google cloud storage commands needs is Storage Object Admin so I didn't want to use a service account with Storage Admin permissions if I didn't have to. Also just to keep the use cases separate |
shrutiag161
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In push_to_airflow.sh: I switched
gsutiltogcloud storagebecausegcloud storageis configured to use the temporary access token returned by GCP.gsutildoesn't accept these tokens (so using a temp auth token wouldn't work and we would need to pass in the actual json key file) and is deprecated by Google Cloud.In an effort to keep permissions separate, I used the
github-actionsservice account which is tied to the github Workload Identity Pool. This service account has "Storage Object Admin" permissions in the necessary GCS buckets accessed bypush_to_airflow.sh.