prepare for prod prof docker images and sample #68
Conversation
Co-authored-by: Arnaud Morvan <[email protected]>
Co-authored-by: Arnaud Morvan <[email protected]>
|
It is also possible to set compose file in .env : For example, but in this case it does not load docker-compose.override.yml automatically. With : It will raise an error if docker-compose.override.yaml does not exists. |
arnaud-morvan
left a comment
arnaud-morvan
left a comment
There was a problem hiding this comment.
Available for discussion
|
@mki-c2c you may have a look at changes in README.md file to update your local config. |
mki-c2c
left a comment
mki-c2c
left a comment
There was a problem hiding this comment.
seems OK
not a fan of the symlink setup, but maybe there are good reasons I did not get.
👍
| environment: | ||
| MAELSTRO_BACK_HOST: maelstro-back | ||
| ports: | ||
| - "8080:8080" |
There was a problem hiding this comment.
I have trouble with this port being opened by default, because it often conflicts with other open projects.
I prefer having the port allocating in the .override file
Unfortunately .override does not allow deactivating ports
But OK, I can always comment this line
| First select the `docker-compose-solo.yml` file as current composition: | ||
|
|
||
| ```bash | ||
| ln -s docker-compose-solo.yml docker-compose.yml |
There was a problem hiding this comment.
why not choose docker-compose-geOrchestra.yml or docker-compose-solo.yml as default (docker-compose-solo.yml), which can be launched via docker compose up -d ?
The other version can be launched via docker compose -f docker-compose-solo.yml up -d This is a more standard way for docker compos, I find the symlinks quite confusing.
However this is a minor issue, the app is working well.
Co-authored-by: Moritz Kirmse <[email protected]>
Co-authored-by: Moritz Kirmse <[email protected]>
Co-authored-by: Moritz Kirmse <[email protected]>
This way we do not have to specify docker-compose file on the command line each time. It is also possible using But in this case it does not load automatically You may need to add it yourself: Regards. |
|
will merge this pr and finish in another, because many differences already |
This PR is to prepare closing the development and prepare for production
also letting possibility to still develop with it