-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 16 #51
base: master
Are you sure you want to change the base?
Issue 16 #51
Conversation
Thanks @jorgejesus. It's enough to restart pywps4-flask with a new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look fine ... but I haven't tested.
@jorgejesus The feature to load processes from a directory is useful in general and we might want to have it in pywps itself (again) ... could be added as an option. It would be kind of a plugin mechanism. A simple implementation to start with is fine. Also we could move the usage of |
I can open a ticket on |
@jachym @jorgejesus @tomkralidis Should we merge this PR? ... or take it as an example and implement it pywps geopython/pywps#118. It has a new example process |
this is an oldone - don't we have already code for automatic process import in the |
yes. We could extend it to load processes from a file path, like done in this PR. |
@cehbrecht, @jachym is this PR still valid/important or we can trash it ? |
I think we don't want to merge it but keep it as reference for the implementation of the |
Overview
Implements issue #16 (Implementaition of
PYWPS_CFG
andPYWPS_PROCESSES
). The demo.py script will pick up the variables from system env and use it. Unitests was write and located intests/test_variables.py
Related Issue / Discussion
@tomkralidis Is it necessary for the directory in
PYWPS_PROCESSES
to be checked for changes and automatically reloaded or is it enough to restart pywps4-flask with a newPYWPS_PROCESSES
There is also a #11 request that needs evaluation based on changed of #51
Additional Information
test_variables.py
doesn't used a live server, and will just make some requests to wps() on demo.py and check that temporaryPYWPS_PROCESSES
andPYWPS_CFG
were acceptedTravis was updated but requires a bit more attention
Contribution Agreement
(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)