suggestion for implementing wms/wmts/wfs/... links in record.geojson #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvgenuchten
force-pushed
the
templated_links
branch
from
dc15c53 to
08d05aa
Compare
|
@pvgenuchten can you rebase? |
pvgenuchten
force-pushed
the
templated_links
branch
from
08d05aa to
a8ce743
Compare
pvgenuchten
force-pushed
the
templated_links
branch
from
a8ce743 to
3fe98a7
Compare
pvgenuchten
commented
Dec 8, 2022
| if 'OGC:WMS' in link['protocol'].upper(): | ||
| link2['rel'] = 'map' | ||
| link2['templated'] = 'true' | ||
| # assumes link['url'] includes '&layers=...', else link['name'] contains layername(s) |
There was a problem hiding this comment.
alternative would be to use owslib.wms130.__build_getmap_request (but challenge to replace bbox array for {bbox})
pvgenuchten
commented
Dec 8, 2022
| 'count': {'type': 'number', 'format': 'integer'}} | ||
| link2['type'] = 'application/gml+xml' | ||
|
|
||
| #elif 'OSGEO:TMS' in link['protocol'].upper(): |
There was a problem hiding this comment.
or better/also to use xyz (both not in catinterop yet, see OSGeo/Cat-Interop#42)
|
@pvgenuchten can you rebase/update this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
populate links in record.geojson for common link types using the suggested templated approach
Related Issue / Discussion
in #814 I raised the question how record.geojson links are modelled from the pycsw datamodel for the typical wms/wfs protocols. This PR presents a suggestion for implementation
Additional Information
A lot of conventions are adopted and discussions are taking place on how one can model a link between a iso19139 metadata record and a specific layer in ows capabilities. In general 2 approaches are common, append on the metadatalink to the service the &layers is parameter to detail the relevant layer, others adopted the &layers={onlineresource.name} convention. This PR supports both cases (but will cause problems if none of the 2 are implemented)
To identify the type of link, the catinterop identifier of the protocol is assumed in link[type], else the link will be treated as a generic link
Contributions and Licensing
(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)