decode q param, when entering it in search box #1037
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
this decodes the q parameter before entering it in the search box, it also replaces + by ' ', because it is not picked up by decode
Related Issue / Discussion
#1036
Additional Information
i'm using js to decode, because the urllib (with quote) library is currently not available in the jinja template, would you prefer to use python to decode?
To some, this may look like a vulnerability option to inject js via querystring, it is not the case, because the q parameter is carefully checked. try things like
https://demo.pycsw.org/cite/collections/metadata:main/items?q=%27%3Cscript%3Ealert(55)%3C%2Fscript%3E
Contributions and Licensing
(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)