adds the contactinfo from dedicated role fields #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkralidis
requested changes
Sep 17, 2024
| @@ -1215,6 +1217,13 @@ def record2json(record, url, collection, mode='ogcapi-records'): | |||
| }) | |||
| except Exception as err: | |||
| LOGGER.exception(f"failed to parse contact of {record.identifier}: {err}") | |||
| for r2 in "creator,publisher,contributor".split(","): # match role-fields with contacts | |||
There was a problem hiding this comment.
I think record is an object here (not a dict)? Perhaps the below can work?
for r2 in ['creator', 'publisher', 'contributor']: # match role-fields with contacts
if r2 not in roles and getattr(record, r2, None) not in [None, '']:
rcnt.append({
'organization': getattr(record, r2),
'roles': [r2]
})There was a problem hiding this comment.
thanx tom, you're right, now fixed and tested
pvgenuchten
force-pushed
the
add-missing-contacts
branch
from
766db72 to
019ef9a
Compare
tomkralidis
requested changes
Oct 3, 2024
pycsw/core/metadata.py
Outdated
| @@ -1651,6 +1651,8 @@ def _parse_dc(context, repos, exml): | |||
|
|
|||
| md = CswRecord(exml) | |||
|
|
|||
| print(md) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the contactinfo from dedicated role fields, if the role does not…already exists in contacts
Overview
the ogcapi- records json fully depends on record.contacts, however in some cases records.contacts is not populated (for example from dublin core), then fall back to the explicit role fields 'creator', 'publisher', 'contributor'.
(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)