-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create build-deploy-staging.yml #204
base: main
Are you sure you want to change the base?
Conversation
added staging branch link for glossary
fixed site generation
site name issue fix
@HassanAkbar looks like the deployment shows 404...? |
@ronaldtse I was testing to deploy the |
hello @HassanAkbar sorry to cause problems with the request for the staging area deployment at first. i am happy to check the updates when they are ready. please send me the URL and i will have a look. thank you. |
@ReesePlews Thanks I am working on it. Will let know as soon as its ready for verification. @ronaldtse I've looked into the subfolder deployment for fontist and from what I understand this was achieved by deploying I think, it is not possible to deploy to a subpath from the same repo. |
@HassanAkbar yes let’s create a new repo for staging so we can deploy to the sub path. Thanks! |
@ronaldtse I've tried testing this using a separate directory by forking this here and the issue is that the URLs will stop working if we deploy it to a sub directory because:
If we try to somehow fix the URLs to work in both environments then it will be a tricky & un-needed effort for adding/maintaining an environment. We will not only have to change in this repo but also in
This will remove the project name from the URL and everything will work as expected. What do you think? |
Can we relax these? |
@ReesePlews you can test the concepts here https://geolexica-staging.github.io. @ronaldtse I didn't want to block the staging testing, so for now I have created a new repo with the staging code and deployed it. If we want to keep this behavior then let me know where to transfer ownership of this repo and if we want to go with custom domain then I can move the workflow to the provided repo. Let me know what you think about this. |
@ronaldtse Just saw your response now, I will have to look into that. I'm not sure if we can do something about the front matter using configuration. I'll check on that and let you know. |
hello @HassanAkbar thank you very much for getting the staging site working. i will be checking it more. i have looked briefly and noticed the following items...
as rendered on FFox for Windows (current release 123.0.1)
if you could check into 1 and 2 that would be great. 3 can wait, not a priority. thank you very much. |
Thanks @ReesePlews for pointing this out. I am already looking into this. |
thank you @HassanAkbar, i appreciate your work on this. @ronaldtse and i have discussed the math syntax a lot. i am sure it will look very nice when implemented. thanks for your continued work! |
@ronaldtse Currently, there is no support for Should we just convert the |
@HassanAkbar Personally I prefer using plurimath because we know the results are consistent. There are a few ways to integrate:
What do you think is better? |
@ronaldtse There are pros and cons to both approaches
I think making a ruby gem here is better. what do you suggest? |
@HassanAkbar I agree with the analysis. In any case, it is possible to skip the broken formulas during processing. |
@ronaldtse I am working on converting the math using Plurimath.
You mentioned that we need to create a gem that extends from So, I've added a I just want to confirm, do we move this hook to a new gem or should I add this to the already present hooks in |
@HassanAkbar keeping in the current gem is fine. Please help merge the finished PRs. Thanks! |
@HassanAkbar please also release any gems as necessary, thanks. |
hello @HassanAkbar and @ronaldtse i know the content at the staging link ( https://geolexica-staging.github.io ) is still under development but i am noticing some other issues that are different from the current geolexica site ( https://isotc211.geolexica.org ) where should i report those issues, can i use this repo or a different one? also, just to confirm that the there will be no change to the content and math encoding style as currently shown on the staging site, is that correct? thanks for all the work on this Hassan! |
@ReesePlews please report all staging issues to this repo. There is no change to the layouts. Thanks! |
@HassanAkbar can this be now merged? Thanks. |
@ronaldtse This needs to be updated now, we have moved the staging site to the |
@HassanAkbar okay, just merge whenever appropriate. Thanks. |
@HassanAkbar is this still needed? What's going on? |
@ronaldtse this is not needed, We need to write a different workflow that will dispatch another workflow in the staging repo. I'll finalize this right after finalizing Lutaml::Model test cases. |
Adding workflow for staging