Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Faker provider #1214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ker0x
Copy link

@ker0x ker0x commented Jan 31, 2024

This PR introduce a faker provider using FakePHP. It's main purpose is to provide fake data during tests.

@jbelien
Copy link
Member

jbelien commented Feb 5, 2024

Hello @ker0x, welcome to the project.
I'm not exactly sure I understand the goal of that new provider, could you give us some use cases ?
Thanks.

@ker0x
Copy link
Author

ker0x commented Feb 5, 2024

@jbelien yes sure.

In my case, I have a listener on some of my entities that geocodes them each time they are created or updated. During my tests, I perform a lot of operations on these entities, and using a real provider slows down the tests because of HTTP calls. I don't particularly need the geocoded data to be accurate during tests, so having a provider with fake data saves me from making these HTTP calls (and it saves requests with some providers that have free request limits per month).

@Chris53897
Copy link
Contributor

@ker0x Could you please revert the changes to other files beside from your new provider, and rebase against master.
This wil make the ci green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants