Fix stack overflow when converting GeometryCollection
scalar to geo
#984
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in a contained comment:
We can't implement both
and
because of this problematic blanket impl
(https://github.com/georust/geo/blob/ef55eabe9029b27f753d4c40db9f656e3670202e/geo-types/src/geometry/geometry_collection.rs#L113-L120).
Thus we need to choose either one or the other to implement.
If we implemented only
for geo::Geometry
, then the default blanket impl forgeo::GeometryCollection
would be wrong because it would doubly-nest theGeometryCollection
:Therefore we must implement only
for geo::GeometryCollection
Closes #979