Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-libs/amdvlk: update to 2024.4.2 #256

Closed
wants to merge 2 commits into from

Conversation

Username404-59
Copy link
Contributor

@Username404-59 Username404-59 commented Oct 31, 2024

Updates the license path patch & adds yet another patch to fix compilation issues

The wrong reference one should get fixed in >=2024.4.2.

@stkw0
Copy link
Contributor

stkw0 commented Nov 4, 2024

CC: @RarogCmex (I saw you made a commit for the update to 2024.4.1 but this PR also changes some other things that may be worth looking at)

@RarogCmex
Copy link
Contributor

RarogCmex commented Nov 4, 2024

@stkw0 To be honest: I am not able to maintain all the changes because of a hard undergraduated curriculum in Financial University Under Russian Government (hell, yeah), but I will do something when I get some free time. I update amdvlk-bin because it takes only around 15 minutes of my mere live.

@stkw0
Copy link
Contributor

stkw0 commented Nov 4, 2024

Yeah no problem. I would have merged this myself but seems a more delicate thing and I don't even have the hardware to test it. Lots of encouragement with the uni!

@Username404-59 I don't know if you are aware, but you can register on GURU (see https://wiki.gentoo.org/wiki/Project:GURU/Information_for_Contributors) and commit directly to the dev branch. You could even help to co-maintain amdvlk if you are interested :)

@Username404-59
Copy link
Contributor Author

@Username404-59 I don't know if you are aware, but you can register on GURU (see https://wiki.gentoo.org/wiki/Project:GURU/Information_for_Contributors) and commit directly to the dev branch. You could even help to co-maintain amdvlk if you are interested :)

I'll maybe look into it 👀

@Username404-59 Username404-59 changed the title media-libs/amdvlk: update to 2024.4.1 media-libs/amdvlk: update to 2024.4.2 Dec 4, 2024
@Username404-59
Copy link
Contributor Author

Updated it to 2024.4.2 which shouldn't need the 2 patches anymore

@stkw0
Copy link
Contributor

stkw0 commented Dec 4, 2024

Will merge it tomorrow :)

I encourage you to register as a contributor. Is this kind of things that may seem complicated but once it's done one realizes it was far more trivial was thought.

@Username404-59
Copy link
Contributor Author

Username404-59 commented Dec 4, 2024

I encourage you to register as a contributor. Is this kind of things that may seem complicated but once it's done one realizes it was far more trivial was thought.

Yep made a request here

EDIT: my bad, wrote trusted contributor but it doesn't work like that lol

gentoo-bot pushed a commit that referenced this pull request Dec 5, 2024
@RarogCmex
Copy link
Contributor

@Username404-59 I have just merged your changes manually so no time is wasted.
Can't wait for your maintainership.
Good luck!

@Username404-59
Copy link
Contributor Author

Username404-59 commented Dec 5, 2024

@Username404-59 I have just merged your changes manually so no time is wasted.

Nice 🎉

EDIT: I've noticed you pushed the missing header patch though? It's not needed anymore, it was for .1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants