Skip to content

Commit

Permalink
mail-client/betterbird-bin: fix QA bugs
Browse files Browse the repository at this point in the history 
Closes: https://bugs.gentoo.org/935522
Closes: https://bugs.gentoo.org/935523
Signed-off-by: Justin Donofrio <[email protected]>
  • Loading branch information
@justin025
justin025 committed Jul 5, 2024
1 parent 9be24a4 commit 2d9e57f
Showing 1 changed file with 25 additions and 1 deletion.
26 changes: 25 additions & 1 deletion mail-client/betterbird-bin/betterbird-bin-115.12.0.ebuild
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ inherit desktop xdg

DESCRIPTION="Betterbird is a fine-tuned version of Mozilla Thunderbird."
HOMEPAGE="https://github.com/Betterbird/thunderbird-patches https://betterbird.eu/"
SRC_URI="https://www.betterbird.eu/downloads/LinuxArchive/betterbird-${PV}-bb29.en-US.linux-x86_64.tar.bz2"
SRC_URI="amd64? ( https://www.betterbird.eu/downloads/LinuxArchive/betterbird-${PV}-bb29.en-US.linux-x86_64.tar.bz2 )"

This comment has been minimized.

Sign in to view

Copy link
@redawl

redawl Jul 7, 2024

Contributor

Why is amd64 checked here? I would assume keywords should handle this.
In other words, only amd64 is supported, so why does this check need to happen?

Also curious about why KEYWORDS="-* ~amd64" is used instead of KEYWORDS="~amd64"

This comment has been minimized.

Sign in to view

Copy link
@redawl

redawl Jul 7, 2024

Contributor

Ok nevermind about the KEYWORDS="-* ~amd64" nitpick, after reading the wiki I understand the use here. However I still think checking the arch in SRC_URI is redundant.

This comment has been minimized.

Sign in to view

Copy link
@justin025

justin025 Jul 7, 2024 •
edited
Loading

Author Contributor

You seem to be right about the SRC_URI, its redundant because the package is already masked by ~amd64. Another dev pushed to master and removed that portion, it looks live I've added it back by accident. 28020df Ill push a new commit with this removed.

S="${WORKDIR}"
LICENSE="MPL-2.0"
Expand All @@ -17,7 +17,29 @@ KEYWORDS="-* ~amd64"
RESTRICT="bindist mirror test strip"

RDEPEND="
app-accessibility/at-spi2-core
dev-libs/dbus-glib
dev-libs/glib
media-libs/alsa-lib
media-libs/fontconfig
media-libs/freetype
sys-apps/dbus
virtual/freedesktop-icon-theme
x11-libs/cairo
x11-libs/gdk-pixbuf:2
x11-libs/gtk+
x11-libs/libX11
x11-libs/libXcomposite
x11-libs/libXcursor
x11-libs/libXdamage
x11-libs/libXext
x11-libs/libXfixes
x11-libs/libXi
x11-libs/libXrandr
x11-libs/libXrender
x11-libs/libXtst
x11-libs/libxcb
x11-libs/pango
"

QA_PREBUILT="*"
Expand All @@ -37,6 +59,8 @@ src_install() {
}

pkg_postinst() {
xdg_pkg_postinst

elog "Language pack XPIs need to be downloaded and installed manually."
elog "Please see the link below for further information."
elog ""
Expand Down

0 comments on commit 2d9e57f

Please sign in to comment.