Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sci-libs/vtk-8.2.0 - drop version #23886

Closed
wants to merge 1 commit into from

Conversation

waebbl
Copy link
Contributor

@waebbl waebbl commented Jan 20, 2022

Only one package, sci-libs/oce, which is masked for last-riting, depends
on this version.
Won't build with ffmpeg-5.

Bug: https://bugs.gentoo.org/831595
Bug: https://bugs.gentoo.org/832625
Package-Manager: Portage-3.0.30, Repoman-3.0.3
Signed-off-by: Bernd Waibel [email protected]

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jan 20, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-01-20 17:21 UTC
Newest commit scanned: 63aaca7
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/1e8fd41369/output.html

@a17r
Copy link
Member

a17r commented Jan 21, 2022

ffmpeg-5 is masked anyway. there is time left to investigate before we introduce upper-bound restrictions everywhere.

@waebbl waebbl marked this pull request as draft January 31, 2022 17:13
@waebbl waebbl marked this pull request as ready for review January 31, 2022 17:14
@waebbl
Copy link
Contributor Author

waebbl commented Jan 31, 2022

Upstream will likely backport a patch for 9.1, but probably not for 9.0.3 and earlier. See https://gitlab.kitware.com/vtk/vtk/-/issues/18445 for status.

@a17r
Copy link
Member

a17r commented Feb 1, 2022

Will it be so complex that we can't backport to 9.0 at least?

@waebbl
Copy link
Contributor Author

waebbl commented Feb 1, 2022

Nope, it doesn't look that complex. I'll give it a try.

@a17r
Copy link
Member

a17r commented Feb 2, 2022

Thanks, we can then add the restriction to 8.x unless it is possible to already cleanup instead.

@waebbl
Copy link
Contributor Author

waebbl commented Feb 2, 2022

It can not be cleaned-up yet, since the sci-libs/oce package depends on v8*.

According to the upstream oce maintainer[1] we might think about last riting sci-libs/oce, depending on revdeps, as it's currently unmaintained and they suggest using opencascade instead.

[1] tpaviot/oce#745 (comment)

@waebbl waebbl force-pushed the vtk-restrict-ffmpeg-5 branch from 63aaca7 to 7c6a695 Compare February 2, 2022 15:46
@a17r
Copy link
Member

a17r commented Feb 2, 2022

@zpuskas ^

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-02-02 16:01 UTC
Newest commit scanned: 7c6a695
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/597da80225/output.html

@waebbl waebbl changed the title sci-libs/vtk-{8.2.0,9.0.3} - restrict to <ffmpeg-5 sci-libs/vtk-{8.2.0,9.0.3} - restrict to <ffmpeg-5 [please reassign] Feb 2, 2022
@gentoo-bot gentoo-bot changed the title sci-libs/vtk-{8.2.0,9.0.3} - restrict to <ffmpeg-5 [please reassign] sci-libs/vtk-{8.2.0,9.0.3} - restrict to <ffmpeg-5 Feb 2, 2022
@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Feb 2, 2022
@waebbl waebbl changed the title sci-libs/vtk-{8.2.0,9.0.3} - restrict to <ffmpeg-5 sci-libs/vtk-8.2.0 - restrict to <ffmpeg-5 Feb 3, 2022
@zpuskas
Copy link
Contributor

zpuskas commented Feb 6, 2022

It can not be cleaned-up yet, since the sci-libs/oce package depends on v8*.

Historically opencascade was slow to release and was less community friendly, thus KiCAD relied on the OCE fork, but this has changed in the 6 series where they only support opencascade now. I've kept the 5 series of KiCAD in the tree as I know that some Gentoo users are using the program for work and I wanted to provide some time for them to migrate to the new version, since it had quite a few non backward compatible changes.

That being said as far as I can see the only user of sci-libs/oce at this point is the sci-electronics/kicad-5.1.12 ebuild. Since we have the KiCAD 6 series in the tree already, I think fist we need to start by dropping the last version of KiCAD 5 series and then we can last rite sci-libs/oce.

This is tracked in https://bugs.gentoo.org/832625.

@waebbl
Copy link
Contributor Author

waebbl commented Feb 6, 2022

That being said as far as I can see the only user of sci-libs/oce at this point is the sci-electronics/kicad-5.1.12 ebuild. Since we have the KiCAD 6 series in the tree already, I think fist we need to start by dropping the last version of KiCAD 5 series and then we can last rite sci-libs/oce.

This is tracked in https://bugs.gentoo.org/832625.

Thanks for your effort. Sounds like a good way to go to me.
I will then drop 8.2.0, once sci-libs/oce has been last rited.

@a17r
Copy link
Member

a17r commented Feb 8, 2022

This PR can now be turned into vtk-8.2.0 cleanup, IINM.

@a17r
Copy link
Member

a17r commented Feb 19, 2022

ping

Only one package, sci-libs/oce, which is masked for last-riting, depends
on this version.
Won't build with ffmpeg-5.

Bug: https://bugs.gentoo.org/831595
Bug: https://bugs.gentoo.org/832625
Package-Manager: Portage-3.0.30, Repoman-3.0.3
Signed-off-by: Bernd Waibel <[email protected]>
@waebbl waebbl force-pushed the vtk-restrict-ffmpeg-5 branch from 7c6a695 to b21a6ff Compare February 20, 2022 10:01
@waebbl waebbl changed the title sci-libs/vtk-8.2.0 - restrict to <ffmpeg-5 sci-libs/vtk-8.2.0 - drop package[please reassign] Feb 20, 2022
@waebbl waebbl changed the title sci-libs/vtk-8.2.0 - drop package[please reassign] sci-libs/vtk-8.2.0 - drop version[please reassign] Feb 20, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-02-20 10:21 UTC
Newest commit scanned: b21a6ff
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/8fe9a60802/output.html

@waebbl waebbl changed the title sci-libs/vtk-8.2.0 - drop version[please reassign] sci-libs/vtk-8.2.0 - drop version [please reassign] Feb 20, 2022
@gentoo-bot gentoo-bot changed the title sci-libs/vtk-8.2.0 - drop version [please reassign] sci-libs/vtk-8.2.0 - drop version Feb 21, 2022
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @waebbl
Areas affected: ebuilds
Packages affected: sci-libs/vtk

sci-libs/vtk: @gentoo/sci, @waebbl, @gentoo/proxy-maint

Linked bugs

Bugs linked: 832625, 831595


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Feb 21, 2022
@waebbl waebbl deleted the vtk-restrict-ffmpeg-5 branch February 24, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants