Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-sound/carla: enable py3.11 #543

Merged
merged 1 commit into from
May 28, 2023
Merged

media-sound/carla: enable py3.11 #543

merged 1 commit into from
May 28, 2023

Conversation

vimproved
Copy link
Contributor

Enables py3.11 and cleans up removed python targets.

@NexAdn
Copy link
Member

NexAdn commented May 26, 2023

Did you test the software with py3.11? We've had experience with build failures for a few packages in the overlay while testing py3.11 compatibility, so I'd like to be sure that we don't break carla by enabling py3.11. A quick “yes” is enough.

The PR in general looks fine, but the pipeline failure does not look good. Seems like the package is unable to install the files correctly.

@vimproved
Copy link
Contributor Author

Did you test the software with py3.11? We've had experience with build failures for a few packages in the overlay while testing py3.11 compatibility, so I'd like to be sure that we don't break carla by enabling py3.11. A quick “yes” is enough.

The PR in general looks fine, but the pipeline failure does not look good. Seems like the package is unable to install the files correctly.

I have tested it with py3.11, and it works fine. No idea why the pipeline failure is happening. I'll check it out.

@vimproved
Copy link
Contributor Author

I can't reproduce the CI failure on my machine, even with the same USE flags.

Signed-off-by: Violet Purcell <[email protected]>
@NexAdn
Copy link
Member

NexAdn commented May 28, 2023

Tested your PR locally. I can't reproduce the build failure either. This might be related to #528, so I'll merge this despite the pipeline failure. I really don't think that this has anything to do with the PYTHON_COMPAT bump and I suspect it won't even affect any user.

Thanks for your contribution!

@NexAdn NexAdn merged commit d30e512 into gentoo-audio:master May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants