Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"usage" example refers to files no longer present in sciclone-meta repo #20

Open
ttriche opened this issue Sep 26, 2016 · 2 comments
Open

Comments

@ttriche
Copy link

ttriche commented Sep 26, 2016

It's a bit confusing to discover that the per-tumor VAF files referred to in Usage have been merged into one file in sciclone-meta/tests/data. So even if one starts out in sciclone-meta/tests, the code in Usage will not run. It might be a good idea to update this since it documents the known working input format for point mutations and SVs (which is of interest to me as I'd like to replace the latter with GRanges-based ploidy calls).

@chrisamiller
Copy link
Collaborator

Yeah, I see your point - I'll see about making them match up better soon. In the meantime, there is some testing code in that meta package that should be useful as well. Thanks for the feedback!

@ttriche
Copy link
Author

ttriche commented Sep 30, 2016

No worries, I forked it to start patching this. I shouldn't bitch about
anything I'm not willing to fix.

--t

On Fri, Sep 30, 2016 at 9:05 AM, Chris Miller [email protected]
wrote:

Yeah, I see your point - I'll see about making them match up better soon.
In the meantime, there is some testing code in that meta package that
should be useful as well. Thanks for the feedback!


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#20 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAARIoe5LYqv1HoUWKsihrSTqBJVDKa-ks5qvTM1gaJpZM4KHGMn
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants