Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional chaining of cy within invalidateCoordsCache. #45

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Optional chaining of cy within invalidateCoordsCache. #45

merged 1 commit into from
Jul 22, 2024

Conversation

dlrice
Copy link
Contributor

@dlrice dlrice commented Jul 22, 2024

When incorporating this wc into the uniprot.org website I encountered the following error many times:

Uncaught TypeError: Cannot read properties of undefined (reading 'renderer') at HTMLDivElement.invalidateCoordsCache (go-loading-spinner_4.entry.js:77903:49)

Optionally chaining cy resolves this.

@kltm
Copy link
Member

kltm commented Jul 22, 2024

Thank you for the PR!
@tmushayahama @pkalita-lbl Any reason not to merge this is for future users?

pkalita-lbl
pkalita-lbl approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@pkalita-lbl pkalita-lbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Thanks!

@kltm kltm merged commit 6ef1fca into geneontology:main Jul 22, 2024
1 check passed
@dlrice dlrice deleted the optional-cy branch July 23, 2024 14:26
@dlrice
Copy link
Contributor Author

dlrice commented Oct 22, 2024

Hi, I only see 1.0.1-beta.2 (five months ago) on NPM for this package. Would you guys be able to create a new release with the fix from this PR?

@kltm
Copy link
Member

kltm commented Oct 22, 2024

Noting #46

@dlrice dlrice mentioned this pull request Oct 24, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkalita-lbl pkalita-lbl pkalita-lbl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlrice @kltm @pkalita-lbl