Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace repository prop with apiUrl prop on wc-gocam-viz component #27

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

pkalita-lbl
Copy link
Contributor

@pkalita-lbl pkalita-lbl commented Oct 19, 2023

Fixes #25

Currently the wc-gocam-viz component has a repository prop which accepts an enum-like set of strings. Based on the value it builds different URLs to fetch the GO-CAM model. These included an endpoint on api.geneontology.xyz as the default, a couple of Barista endpoints (which we don't want to use at all anymore), and a localhost endpoint which would only be useful for certain local development scenarios.

With these changes the release prop is removed and a new apiUrl prop is added. The default is the new api.geneontology.org endpoint. Since changing the API endpoint should be a fairly rare use case I've also removed the select box from the dev/demo pages. If you needed to point the widget to a local endpoint for development, you'd temporarily change the dev/demo page by adding the appropriate attribute (e.g. api-url='http://localhost/path/to/endpoint/%ID) to the wc-gocam-viz element.

cc: @kltm

@pkalita-lbl pkalita-lbl marked this pull request as ready for review October 20, 2023 21:39
Copy link
Member

@kltm kltm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code to remove repository, in favor of apiUrl, with some other minor fixes. Likely does as advertised.

This can be self-merged whenever is convenient for others.

@pkalita-lbl pkalita-lbl merged commit f8d2698 into main Oct 23, 2023
1 check passed
@pkalita-lbl pkalita-lbl deleted the issue-25 branch October 23, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Purge code of references to barista and non-standard endpoints; standardize on api.geneontology.org
2 participants