Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements.txt for #844 #2004

Merged
merged 16 commits into from
Sep 12, 2023
Merged

Conversation

mugitty
Copy link
Contributor

@mugitty mugitty commented Apr 24, 2023

Bringing in changes from biolink/ontobio#632

Will test on Jenkins test branch

@mugitty mugitty requested review from dustine32 and kltm April 24, 2023 19:15
@kltm
Copy link
Member

kltm commented Apr 25, 2023

@mugitty This is a trivial change, so merge at will.

@kltm
Copy link
Member

kltm commented Apr 25, 2023

@mugitty @dustine32 It looks like your pipeline has failed. Odd error in the reports. Are you up-to-date with master/snapshot?

@mugitty
Copy link
Contributor Author

mugitty commented Apr 25, 2023

Jenkins file got to be large, so I temporarily removed part of the publishing step. This may have caused the problem. I need to look in detail

@kltm
Copy link
Member

kltm commented Apr 26, 2023

@mugitty Importantly, "Publishing" and "Archiving" should be either kept intact or removed entirely--having a partial publish step could cause problems, such as overwriting live data with bad data.
That said, it was in reports where it failed, so I'd doubt the error was there.

@mugitty
Copy link
Contributor Author

mugitty commented Apr 26, 2023

It failed while comparing stats from previous to current release. Specifically, it cannot find 'process' aspect items in the json file.

@dustine32
Copy link
Contributor

65b1bdf is for fixing pip install ../graphstore/rule-runner errors:

20:00:22  Collecting SPARQLWrapper==1.8.0
20:00:22    Downloading SPARQLWrapper-1.8.0.zip (36 kB)
20:00:22    Preparing metadata (setup.py): started
20:00:22    Preparing metadata (setup.py): finished with status 'error'
20:00:22    error: subprocess-exited-with-error
20:00:22    
20:00:22    × python setup.py egg_info did not run successfully.
20:00:22    │ exit code: 1
20:00:22    ╰─> [1 lines of output]
20:00:22        error in SPARQLWrapper setup command: use_2to3 is invalid.
20:00:22        [end of output]

Also another error installing pyYaml==5.4.1:

        (a long, long stack trace and then...)
        File "/private/var/folders/mn/4r4wdgk16z7cvnq3t2zrhkf40000gp/T/pip-build-env-dvoojr4k/overlay/lib/python3.10/site-packages/setuptools/_distutils/command/sdist.py", line 251, in add_defaults
          self._add_defaults_ext()
        File "/private/var/folders/mn/4r4wdgk16z7cvnq3t2zrhkf40000gp/T/pip-build-env-dvoojr4k/overlay/lib/python3.10/site-packages/setuptools/_distutils/command/sdist.py", line 336, in _add_defaults_ext
          self.filelist.extend(build_ext.get_source_files())
        File "<string>", line 201, in get_source_files
        File "/private/var/folders/mn/4r4wdgk16z7cvnq3t2zrhkf40000gp/T/pip-build-env-dvoojr4k/overlay/lib/python3.10/site-packages/setuptools/_distutils/cmd.py", line 107, in __getattr__
          raise AttributeError(attr)
      AttributeError: cython_sources

We'll see in testing how this affects the GO pipeline build and whether we need to pin to any specific versions.

Copy link
Contributor

@dustine32 dustine32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mugitty and I sorted out the python3.10 upgrade bugs on this branch as we saw them pop up on the Jenkins build pipeline. A lot of unpinning dependencies.

Hopefully this is everything we need to do. But if there are more, newly discovered bugs we can just continue to fight through them.

@mugitty mugitty merged commit afa4be6 into master Sep 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants