Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an example for exporting model to VTK #924

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yangjiandendi
Copy link

Description

added an example for exporting GemPy model to VTK model and getting the vertices of model mesh in Example 01.

Relates to <#922>

Checklist

  • My code follows the PEP 8 style guidelines.
  • My code uses type hinting for function and method arguments and return values.
  • My code contains descriptive and helpful docstrings
    which are formatted per the Google Python Style Guidelines.
  • I have created tests which entirely cover my code.
  • The test code either 1. demonstrates at least one valuable use case (e.g. integration tests)
    or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).
  • New and existing tests pass locally with my changes.

@Leguark Leguark self-requested a review August 27, 2024 09:45
@Leguark
Copy link
Member

Leguark commented Aug 27, 2024

Hi yangjiandi. Thanks for the pull request, this can be a nice example for other people. However, to add it to the documentation it should be converted to a .py file with similar syntax as the other examples. This makes possible to build sphinx documentation. If you convert it into a .py file I can continue the review.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants