Respect explicit source: option on gem entries
#130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were collecting them as valid sources in general, but were not enforcing that those particular gems may _only_ come from the stated catalog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were collecting them as valid sources in general, but were not enforcing that those particular gems may only come from the stated catalog.
This particular behaviour was an oversight, but more generally, now that newer Bundler is comfortable with multiple separate
GEMblocks for multiple catalog sources, we should probably also move that direction. My memory claims I got part way down that path earlier, before deciding we had to follow Bundler's squish-everything-together precedent... but I don't recall whether that involved actual recoverable code, or just some conceptual choices during implementation.