-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stick the gel command in the enviornment #124
Open
tenderlove
wants to merge
1
commit into
gel-rb:main
Choose a base branch
from
tenderlove:add-program-name
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am trying to install Rails using Gel only. But the Rails installation scripts have a hard dependency on Bundler [here](https://github.com/rails/rails/blob/df1e1bc35c6210ecb39532a06823a6cf4f07bcd8/railties/lib/rails/generators/app_base.rb#L392-L397). To fix this, I want to add necessary features so that Gel can replace this code. The first issue I want to tackle is [this line](https://github.com/rails/rails/blob/df1e1bc35c6210ecb39532a06823a6cf4f07bcd8/railties/lib/rails/generators/app_base.rb#L392) that tries to get the Bundler executable. I don't use Gel from RubyGems, so it doesn't really make sense to ask `Gem` what the path is for the Gel executable. To get around this issue, I would like to stick the Gel program name in the environment as `GEL_PROGRAM_NAME`. Then when I do: ``` $ gel exec rails new ~/git/blah ``` Rails will know that it's being executed with Gel, and it will also know where to find the Gel binfile so that the install process can `gel install` on the newly created Rails app.
The actual command I'm trying to execute is The error I see is this:
|
isimluk
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to install Rails using Gel only. But the Rails installation
scripts have a hard dependency on Bundler
here.
To fix this, I want to add necessary features so that Gel can replace
this code. The first issue I want to tackle is this
line
that tries to get the Bundler executable. I don't use Gel from
RubyGems, so it doesn't really make sense to ask
Gem
what the path isfor the Gel executable. To get around this issue, I would like to stick
the Gel program name in the environment as
GEL_PROGRAM_NAME
. Thenwhen I do:
Rails will know that it's being executed with Gel, and it will also know
where to find the Gel binfile so that the install process can
gel install
on the newly created Rails app.