feat(test): add tests that run outside of a Git repo

gekoke · May 20, 2024 · 3345811 · 3345811
1 parent fc7c551
commit 3345811
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 19 deletions.
diff --git a/nix/packages.nix b/nix/packages.nix
@@ -14,19 +14,20 @@ _: {
           packageRequires = [
             pkgs.emacsPackages.el-patch
             pkgs.emacsPackages.nerd-icons
+            pkgs.emacsPackages.magit
           ];
 
           doCheck = true;
 
           nativeCheckInputs = [
             pkgs.git
             pkgs.emacs
-            pkgs.emacsPackages.magit
           ] ++ packageRequires;
 
           checkPhase = ''
-            git init # need to be in repository for Magit tests to not fail
             emacs --batch -l ert -l magit-file-icons.el -l ./test/magit-file-icons-tests.el -f ert-run-tests-batch-and-exit
+            git init
+            emacs --batch -l ert -l magit-file-icons.el -l ./test/magit-file-icons-git-repo-tests.el -f ert-run-tests-batch-and-exit
           '';
 
           meta = {

diff --git a/test/magit-file-icons-git-repo-tests.el b/test/magit-file-icons-git-repo-tests.el
@@ -0,0 +1,29 @@
+;; -*- lexical-binding: t; -*-
+
+(require 'ert)
+(require 'el-patch)
+(require 'magit-file-icons)
+
+(ert-deftest magit-file-icons-test-can-open-magit-status-buffer-while-in-minor-mode ()
+  (magit-file-icons-mode +1)
+  (magit-status-setup-buffer))
+
+(ert-deftest magit-file-icons-test-can-enable-minor-mode-in-magit-status-buffer ()
+  (magit-status-setup-buffer)
+  (magit-file-icons-mode +1))
+
+(ert-deftest magit-file-icons-test-can-disable-minor-mode-in-magit-status-buffer ()
+  (magit-file-icons-mode +1)
+  (magit-status-setup-buffer)
+  (magit-file-icons-mode -1))
+
+(ert-deftest magit-file-icons-test-can-toggle-minor-mode-in-magit-status-buffer ()
+  (magit-file-icons-mode +1)
+  (magit-status-setup-buffer)
+  (magit-file-icons-mode 'toggle)
+  (magit-file-icons-mode 'toggle))
+
+;; Local Variables:
+;; flycheck-disabled-checkers: (emacs-lisp-checkdoc)
+;; End:
+
diff --git a/test/magit-file-icons-tests.el b/test/magit-file-icons-tests.el
@@ -7,25 +7,9 @@
 (ert-deftest magit-file-icons-test-has-no-invalid-templates ()
   (el-patch-validate-all-templates))
 
-(ert-deftest magit-file-icons-test-can-open-magit-status-buffer-while-in-minor-mode ()
-  (magit-file-icons-mode +1)
-  (magit-status-setup-buffer))
-
-(ert-deftest magit-file-icons-test-can-enable-minor-mode-in-magit-status-buffer ()
-  (magit-status-setup-buffer)
+(ert-deftest magit-file-icons-test-can-load-minor-mode-outside-of-git-repo ()
   (magit-file-icons-mode +1))
 
-(ert-deftest magit-file-icons-test-can-disable-minor-mode-in-magit-status-buffer ()
-  (magit-file-icons-mode +1)
-  (magit-status-setup-buffer)
-  (magit-file-icons-mode -1))
-
-(ert-deftest magit-file-icons-test-can-toggle-minor-mode-in-magit-status-buffer ()
-  (magit-file-icons-mode +1)
-  (magit-status-setup-buffer)
-  (magit-file-icons-mode 'toggle)
-  (magit-file-icons-mode 'toggle))
-
 ;; Local Variables:
 ;; flycheck-disabled-checkers: (emacs-lisp-checkdoc)
 ;; End: