Cleanup Systemd files and add Travis-CI test for Systemd (Rebased) #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| rm -f /lib/systemd/system/basic.target.wants/*;\ | ||
| rm -f /lib/systemd/system/anaconda.target.wants/*; \ | ||
| rm -f /lib/systemd/system/systemd*udev*; \ | ||
| rm -f /lib/systemd/system/getty.target |
There was a problem hiding this comment.
Why the multiple rms ?
There are also whitespace inconsistencies ;-)
There was a problem hiding this comment.
This was just a rebase of #12 where they explained those files need to be removed to fix problems with systemd in a container running in a systemd system. The biggest problem is the container causes the container to log the user of the host out when it stops. Why multiple rms instead of a single rm. No real reason I was just rebasing the pull because @geerlingguy asked the original guy to rebase but the original guy wasn't responding. Same goes for the whitespace inconsistency.
|
Since this is way out of date and 18.04 is nearly EOL just closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to make sure you could say yes to #12 so I rebased it on your master and consolidated the systemd clean up lines.