Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App ext block size fix feature #18

Open
wants to merge 6 commits into
base: gh-pages
Choose a base branch
from

Conversation

soranoba
Copy link
Contributor

Application header that has been extended by Netscape are sometimes used in animation gif.
(ex. when it made from mp4 using ffmpeg)
However, if there is this header, the x-gif was not available.

I fix this =)

@geelen
Copy link
Owner

geelen commented Jun 17, 2014

Hey there, I've found a bit of a bug with this. I've just added a new demo page at http://localhost:1983/demos/visual_test.html just to make sure none of these changes introduce major problems. With this branch, I'm seeing problems with the pulse.gif.

Could you either merge geelen:gh-pages or geelen:pr/18 to see the new demo file and take a look? If you want to add another file with the extended headers to test this branch, that would be cool too.

I merged the other branch though, that fixed a bug with quite a few GIFs, so thanks!!

@soranoba
Copy link
Contributor Author

Hey geelen. I'm sorry to send PR that had a bug.
I had misunderstood the specification of streamReader.readAscii.
Do not repaired with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants