Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen Ruby version requirement to 1.9.2. #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Loosen Ruby version requirement to 1.9.2. #2

wants to merge 1 commit into from

Conversation

louismullie
Copy link

There is no feature currently used by this gem that is not supported on Ruby 1.9.2. The 1.9.3 requirement precludes testing of gems that require this one in a Ruby 1.9.2 environment. It would be great to relax the Ruby version requirement to 1.9.2.

@louismullie
Copy link
Author

Are you interested in merging this?

@ged
Copy link
Owner

ged commented Jan 9, 2013

Sorry, I just started a new job, so I'm still catching up on pull requests and bug reports.

In general, I want to support people using stuff under whatever version of Ruby they need, but I also feel like setting the requirements indicates an assurance that the library works under that version. Since I don't test this library under any version earlier than 1.9.3, I'm torn as to what to do for your situation. It clearly needs a version requirement to avoid people trying to use it with 1.8.x, but I don't want to cause undo trouble for people that are stuck on an earlier version of 1.9.x either.

Any thoughts? Do you have to do anything other than 'gem install -f' to get it to install under 1.9.2?

@louismullie
Copy link
Author

It's a bit more complicated than 'gem install -f' for me, since I'm dynamically installing the gem within a Ruby script. My position is that since you're not using any Ruby 1.9.3 specific features, the gem should install cleanly on Ruby 1.9.2. It would also be simpler for users who are installing on Ruby 1.9.2, since they wouldn't have to lookup how to bypass the version requirement. Also, I'm spec testing many parts of the gem as part of my library, so if anything big breaks, I should be able to catch it (but I really don't see any way this could happen).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants